[webkit-reviews] review denied: [Bug 26620] Haiku WebKit port : [Attachment 32073] Patch to add Haiku-specific files for WebCore/page/.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 2 14:44:31 PDT 2009
Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620
Attachment 32073: Patch to add Haiku-specific files for WebCore/page/.
https://bugs.webkit.org/attachment.cgi?id=32073&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Please don't include commented out code:
//#include "Frame.h"
32 //#include "FrameView.h"
33 //#include "Page.h"
108 //notImplemented();
Looks OK otherwise. Please remove extra comments and update changeLog and
re-post. I would have r+'d this if you were a committer.
8 WARNING: NO TEST CASES ADDED OR CHANGED
More information about the webkit-reviews
mailing list