[webkit-reviews] review denied: [Bug 26620] Haiku WebKit port : [Attachment 32071] Patch to add Haiku-specific files for WebCore/editing/.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 2 14:42:45 PDT 2009
Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620
Attachment 32071: Patch to add Haiku-specific files for WebCore/editing/.
https://bugs.webkit.org/attachment.cgi?id=32071&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine. Where is the implementation of ClipboardHaiku?
R- for someone having to edit your ChangeLogs when landing:
+ WARNING: NO TEST CASES ADDED OR CHANGED
(If you were a committer I would just r+ all these, but as is, it's best if you
fix them first so they can be landed automatically by our scripts.)
More information about the webkit-reviews
mailing list