[webkit-reviews] review cancelled: [Bug 18343] [GTK] Soup backend must handle upload of multiple files : [Attachment 27134] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 29 12:13:04 PST 2009


Gustavo Noronha Silva <gns at gnome.org> has cancelled Gustavo Noronha Silva
<gns at gnome.org>'s request for review:
Bug 18343: [GTK] Soup backend must handle upload of multiple files
https://bugs.webkit.org/show_bug.cgi?id=18343

Attachment 27134: proposed patch
https://bugs.webkit.org/attachment.cgi?id=27134&action=review

------- Additional Comments from Gustavo Noronha Silva <gns at gnome.org>
This patch only adds a TODO comment regarding the usage of the accumulate flag.
We would have to require a development version of libsoup, so I'd rather wait
'till we are far enough into the future, or have ways of #ifdef'ing the line
before adding it. As Dan says, this would improve performance, but not setting
it to FALSE doesn't make the code incorrect.


More information about the webkit-reviews mailing list