[webkit-reviews] review denied: [Bug 23536] Auto-generate HTMLElementFactory : [Attachment 27057] Last bits (again) - tweaked to remove some differences between generated and non-generated

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Julien Chaffraix
<jchaffraix at pleyo.com>'s request for review:
Bug 23536: Auto-generate HTMLElementFactory
https://bugs.webkit.org/show_bug.cgi?id=23536

Attachment 27057: Last bits (again) - tweaked to remove some differences
between generated and non-generated
https://bugs.webkit.org/attachment.cgi?id=27057&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This isn't ready yet.

Notice that image no longer uses the form element in your generated copy.  Your
generated copy also doesn't support disabling video? (maybe it doesn't need to
cause it generates w/o the video tags when video is off?)

I think the generated version should also use something like addTag for better
readability of the generated output.

There are a couple returns missing from the typedef line for the constructor
function at teh top of the line.

I would encourge you to fully sort the original file, and then generate yours
side by side and compare again.

This is really close, but we need it to be perfect before we can replace the
hand-rolled version or we'll have bugs!