[webkit-reviews] review requested: [Bug 16135] [GTK] Support caret browsing : [Attachment 27073] Caret browsing v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 27 06:15:19 PST 2009

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 16135: [GTK] Support caret browsing

Attachment 27073: Caret browsing v3

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
I started refactoring the code in EditorClientGTK to handle properly events
with caret browsing (most keys but up/down/left/right would not work in caret
mode, for example), and halfway through realized I was basically getting to do
what was already done in the Windows port. So I took that code and modified it
to handle differently up/down/left/right keys in caret mode instead.

With this the keys works as expected in both caret and non-caret mode, and I
haven't been able to reproduce the "getting stuck in a node" bug either (but I
couldn't say if it's gone for good).

More information about the webkit-reviews mailing list