[webkit-reviews] review cancelled: [Bug 16135] [GTK] Support caret browsing : [Attachment 27035] 0001-Update-alp-s-patch-to-trunk.patch

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has cancelled Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 16135: [GTK] Support caret browsing
https://bugs.webkit.org/show_bug.cgi?id=16135

Attachment 27035: 0001-Update-alp-s-patch-to-trunk.patch
https://bugs.webkit.org/attachment.cgi?id=27035&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
I started refactoring the code in EditorClientGTK to handle properly events
with caret browsing (most keys but up/down/left/right would not work in caret
mode, for example), and halfway through realized I was basically getting to do
what was already done in the Windows port. So I took that code and modified it
to handle differently up/down/left/right keys in caret mode instead.

With this the keys works as expected in both caret and non-caret mode, and I
haven't been able to reproduce the "getting stuck in a node" bug either (but I
couldn't say if it's gone for good).