[webkit-reviews] review requested: [Bug 17375] Set user-agent from application : [Attachment 27004] Implement "user-agent" web settings property

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 24 19:37:41 PST 2009


Christian Dywan <christian at imendio.com> has asked  for review:
Bug 17375: Set user-agent from application
https://bugs.webkit.org/show_bug.cgi?id=17375

Attachment 27004: Implement "user-agent" web settings property
https://bugs.webkit.org/attachment.cgi?id=27004&action=review

------- Additional Comments from Christian Dywan <christian at imendio.com>
This is a patch that implements "user-agent" as a new property of the web
settings. It is probably not quite done, for instance I didn't check whether
the string also needs to be applied on frames or whether the frame loader
client is valid when it is set.

I patched GtkLauncher to verify that the new feature works correctly. I would
leave that part out in the commit.

If we agree on adding this I can look into the mentioned open issues.


More information about the webkit-reviews mailing list