[webkit-reviews] review requested: [Bug 14807] [gtk] API implementation: url and title : [Attachment 27003] Implement title and uri on the view

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 24 17:25:07 PST 2009


Christian Dywan <christian at imendio.com> has asked  for review:
Bug 14807: [gtk] API implementation: url and title
https://bugs.webkit.org/show_bug.cgi?id=14807

Attachment 27003: Implement title and uri on the view
https://bugs.webkit.org/attachment.cgi?id=27003&action=review

------- Additional Comments from Christian Dywan <christian at imendio.com>
Our API is still inconsistent in such simple cases. The frame has URI and title
accessors and properties, while the view has not. That leads to clumsy calls to
webkit_web_view_get_main_frame where anything like a data source would be
overkill. On top of that there are no property notifications at all, so the
frame properties are even only half usable.

I suggest that we fix the frame properties and implement the very same
properties on the view. Most of the webkit applications will find this enough
for all they ever need. The attached patch does that.

Come to think of it, what about making URI writable? It's pure convenience but
would allow for neat tricks like applying an initial location in g_object_new
or loading a page inside a graphical interface builder.


More information about the webkit-reviews mailing list