[webkit-reviews] review cancelled: [Bug 23488] Make TimerBase thread-aware. For use in Workers. : [Attachment 26964] Proposed patch, v2

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has cancelled Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 23488: Make TimerBase thread-aware. For use in Workers.
https://bugs.webkit.org/show_bug.cgi?id=23488

Attachment 26964: Proposed patch, v2
https://bugs.webkit.org/attachment.cgi?id=26964&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Looking at it a bit more, fixed following:
- in multiple threads case, the timers can be created before worker thread
initializes SharedTimer, and SharedTimer pointer may be set to 0 before all the
timers are removed. Add check to avoid calling to SharedTimer when it's 0. (in
setSharedTimer, updateSharedTimer)

- made ThreadTimers::m_timerHeap an instance of a Vector rather then a pointer
to avoid it leaking when ThreadTimers gets destroyed (it does if its thread is
not a main one)