[webkit-reviews] review requested: [Bug 23488] Make TimerBase thread-aware. For use in Workers. : [Attachment 26985] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 23 14:48:52 PST 2009

Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 23488: Make TimerBase thread-aware. For use in Workers.

Attachment 26985: Updated patch

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Looking at it a bit more, fixed following:
- in multiple threads case, the timers can be created before worker thread
initializes SharedTimer, and SharedTimer pointer may be set to 0 before all the
timers are removed. Add check to avoid calling to SharedTimer when it's 0. (in
setSharedTimer, updateSharedTimer)

- made ThreadTimers::m_timerHeap an instance of a Vector rather then a pointer
to avoid it leaking when ThreadTimers gets destroyed (it does if its thread is
not a main one)

More information about the webkit-reviews mailing list