[webkit-reviews] review granted: [Bug 23435] Make SVG spreadMethod a member of Gradient rather than GraphicsContext : [Attachment 26918] try6
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 22 21:12:22 PST 2009
Nikolas Zimmermann <zimmermann at kde.org> has granted Evan Stade
<estade at chromium.org>'s request for review:
Bug 23435: Make SVG spreadMethod a member of Gradient rather than
GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=23435
Attachment 26918: try6
https://bugs.webkit.org/attachment.cgi?id=26918&action=review
------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Most issues seem resolved, r=me - just one minor style issue:
> + void setSpreadMethod(GradientSpreadMethod spreadMethod);
> +
> + GradientSpreadMethod spreadMethod() { return m_spreadMethod; }
You can remove the newline between those methods, and omit the parameter name
in setSpreadMethod, so it just reads 'void
setSpreadMethod(GradientSpreadMethod);'
You don't need to upload another patch, just fix that issue before landing.
More information about the webkit-reviews
mailing list