[webkit-reviews] review denied: [Bug 23322] gtk2drawing.c: fix compile warnings : [Attachment 26715] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 22 21:00:29 PST 2009


Nikolas Zimmermann <zimmermann at kde.org> has denied Adam Langley
<agl at google.com>'s request for review:
Bug 23322: gtk2drawing.c: fix compile warnings
https://bugs.webkit.org/show_bug.cgi?id=23322

Attachment 26715: proposed patch
https://bugs.webkit.org/attachment.cgi?id=26715&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
The patch looks fine, though I think using GINT_TO_POINTER(TRUE/FALSE) sounds
more approriate, then just casting to (gpointer)? I'm not a Gtk expert, but
I've seen the style I suggested before.


More information about the webkit-reviews mailing list