[webkit-reviews] review requested: [Bug 23435] Pass SVG spreadMethod to Gradient::platformGradient() and use it on Skia : [Attachment 26916] try4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 21 16:45:24 PST 2009


Evan Stade <estade at chromium.org> has asked  for review:
Bug 23435: Pass SVG spreadMethod to Gradient::platformGradient() and use it on
Skia
https://bugs.webkit.org/show_bug.cgi?id=23435

Attachment 26916: try4
https://bugs.webkit.org/attachment.cgi?id=26916&action=review

------- Additional Comments from Evan Stade <estade at chromium.org>
> We use "0" instead of "NULL" in WebKit.

Ok.

> But why does m_gradient have to be null? ...

OK, but I left the ASSERT to avoid future head-banging since the current use
pattern should never hit this ASSERT and it would only be hit if someone made
changes.

> Thanks for the nice work!

thanks for the review


More information about the webkit-reviews mailing list