[webkit-reviews] review granted: [Bug 23435] Pass SVG spreadMethod to Gradient::platformGradient() and use it on Skia : [Attachment 26911] move spreadMethod attribute to Gradient (from GraphicsContext)

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Evan Stade
<estade at chromium.org>'s request for review:
Bug 23435: Pass SVG spreadMethod to Gradient::platformGradient() and use it on
Skia
https://bugs.webkit.org/show_bug.cgi?id=23435

Attachment 26911: move spreadMethod attribute to Gradient (from
GraphicsContext)
https://bugs.webkit.org/attachment.cgi?id=26911&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Patch looks much better, r+, with one comments:
  
> +	   void setSpreadMethod(GradientSpreadMethod spreadMethod) {
> +	       ASSERT(m_gradient == NULL);
> +	       m_spreadMethod = spreadMethod;
> +	   }

We use "0" instead of "NULL" in WebKit. But why does m_gradient have to be
null?
I'd rather implement the setSpreadMethod in Gradient.cpp, and add a FIXME to
handle
dynamic spread method changes (when m_gradient has already been created),
instead
of asserting

Thanks for the nice work!