[webkit-reviews] review requested: [Bug 23426] Frame Refactor: Move isFrameSet to Document : [Attachment 26856] Carry out the move

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 20 04:35:40 PST 2009


Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 23426: Frame Refactor: Move isFrameSet to Document
https://bugs.webkit.org/show_bug.cgi?id=23426

Attachment 26856: Carry out the move
https://bugs.webkit.org/attachment.cgi?id=26856&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
I think the added null check (if correct) looks ugly and it would be a case for
leaving isFrameSet in Frame. Test cases pass on the mac.


More information about the webkit-reviews mailing list