[webkit-reviews] review requested: [Bug 22720] Make XMLHttpRequest work in Workers : [Attachment 26855] Part 2: More work on cleaning up instances of document in the XMLHttpRequest class.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 20 00:35:52 PST 2009
David Levin <levin at chromium.org> has asked for review:
Bug 22720: Make XMLHttpRequest work in Workers
https://bugs.webkit.org/show_bug.cgi?id=22720
Attachment 26855: Part 2: More work on cleaning up instances of document in the
XMLHttpRequest class.
https://bugs.webkit.org/attachment.cgi?id=26855&action=review
------- Additional Comments from David Levin <levin at chromium.org>
Some things that you may want to note:
1. I didn't make the files that I added to the xcode project "private". Some
files are and some aren't and I didn't get the distinction to understand what
to do.
2. didFail() got split into two methods, but the original didFail() picked up a
call to internalAbort(); As far as I could tell this is all fine, but it was
needed to mimic the old behavior of willSendRequest.
More information about the webkit-reviews
mailing list