[webkit-reviews] review denied: [Bug 23318] click event listener remains registered after onclick attribute is removed : [Attachment 26710] proof of concept patch -- not intended to be landed

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Cary Clark <caryclark at google.com>'s
request for review:
Bug 23318: click event listener remains registered after onclick attribute is
removed
https://bugs.webkit.org/show_bug.cgi?id=23318

Attachment 26710: proof of concept patch -- not intended to be landed
https://bugs.webkit.org/attachment.cgi?id=26710&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
The first thing we need here is a test case to demonstrate the problem. The
details of the problem could be different with different node types, for
example, with the window. And the failure may be caused by some other code
change or some port-specific issue. A test case cuts through all those issues
and lets everyone see that something is really wrong.

The function responsible for handling this sort of thing is
EventTargetNode::removeInlineEventListenerForType. In the failing test case,
you should figure out if the problem is that function is not being called, or
if the that function is not working properly. Specifically, if you change the
value of the onclick attribute on a <button> element to the empty string (to
choose a specific example, because there are many different code paths), then:

    EventTargetNode::setOnclick will call
    EventTargetNode::setInlineEventListenerForType, which will call
    EventTargetNode::removeInlineEventListenerForType, which will remove the
listener that was added