[webkit-reviews] review granted: [Bug 23316] Application cache updating always fails with an assertion : [Attachment 26706] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 23316: Application cache updating always fails with an assertion
https://bugs.webkit.org/show_bug.cgi?id=23316

Attachment 26706: proposed patch
https://bugs.webkit.org/attachment.cgi?id=26706&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    // Release our reference to the newest cache. This could cause us to be
deleted.
> +    // Any ongoing updates will be stopped from destructor.
> +    m_savedNewestCachePointer = m_newestCache.release().get();

I think it would be clearer to write this like this:

    m_savedNewestCachePointer = m_newestCache.get();
    m_newestCache.clear();

That's because release() is a function used to transfer ownership, and we're
really not doing that.

r=me