[webkit-reviews] review granted: [Bug 23298] Need to be tolerant of null style values passed to CSSStyleSelector::convertToLength : [Attachment 26677] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 13 11:49:04 PST 2009
Darin Adler <darin at apple.com> has granted Chris Marrin <cmarrin at apple.com>'s
request for review:
Bug 23298: Need to be tolerant of null style values passed to
CSSStyleSelector::convertToLength
https://bugs.webkit.org/show_bug.cgi?id=23298
Attachment 26677: Patch
https://bugs.webkit.org/attachment.cgi?id=26677&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> + if (!style && (type == CSSPrimitiveValue::CSS_EMS || type ==
CSSPrimitiveValue::CSS_EXS)) {
> + if (ok)
> + *ok = false;
> + }
> + else if (type > CSSPrimitiveValue::CSS_PERCENTAGE && type <
CSSPrimitiveValue::CSS_DEG)
Brace goes on same line as else in the WebKit coding style.
r=me
More information about the webkit-reviews
mailing list