[webkit-reviews] review granted: [Bug 23297] Upstream some of platform/graphics/chromium : [Attachment 26676] add a few font-related files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 13 11:44:41 PST 2009

Eric Seidel <eric at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 23297: Upstream some of platform/graphics/chromium

Attachment 26676: add a few font-related files

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks good except for:
 #ifndef FontPlatformData_h
 32 #define FontPlatformData_h
 34 #include "config.h"
 35 #include "build/build_config.h"
 37 #if defined(OS_WIN)
 38 #include "FontPlatformDataChromiumWin.h"
 39 #elif defined(OS_LINUX)
 40 #include "FontPlatformDataLinux.h"
 41 #endif

We never include config.h in a header.	And I would think we should use WebCore
equivilents to the OS_ defines, like PLATFORM(WIN_OS) and defined(__linux__)
(since we don't seem to have a PLATFORM(LINUX).  Otherwise you're good to land.

More information about the webkit-reviews mailing list