[webkit-reviews] review denied: [Bug 23069] Generic section filtering with recessed buttons : [Attachment 26357] first patch iteration. see changelog in patch for further details

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Konstantin Käfer <kkaefer at gmail.com>'s
request for review:
Bug 23069: Generic section filtering with recessed buttons
https://bugs.webkit.org/show_bug.cgi?id=23069

Attachment 26357: first patch iteration. see changelog in patch for further
details
https://bugs.webkit.org/attachment.cgi?id=26357&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
The screen shot seems to show two changes:

    1) the check box is changed into a button you can depress, one that looks
like a Mac OS X "scope button"
    2) the layout of lines that overflow is better; the main title ends up on
the top line and the subtitle ends up on second line, instead of backwards and
truncating

Change (2) seems like a nice improvement.

Change (1) does not seem good. The check box makes more logical sense and we
don't want something that looks like a "scope button" but doesn't act like one.


I'd rather that the main designer of the inspector UI, Tim Hatcher, comment
here, but since Mark Rowe and I are both in agreement that we don't want (1)
I'm going to say review- on this patch for now.