[webkit-reviews] review granted: [Bug 23163] suppress scrolling in Element::updateFocusAppearance : [Attachment 26491] don't scroll when setting focus for devices with directional pad navigation

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Cary Clark <caryclark at google.com>'s
request for review:
Bug 23163: suppress scrolling in Element::updateFocusAppearance
https://bugs.webkit.org/show_bug.cgi?id=23163

Attachment 26491: don't scroll when setting focus for devices with directional
pad navigation
https://bugs.webkit.org/attachment.cgi?id=26491&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
It seems to me that the real issue here isn't exactly "directional pad
navigation" -- it's more "small screen with explicit scrolling", and I suppose
the explicit scrolling part is what's really relevant. I could easily imagine
someone using WebKit on a web browser for a TV screen, and using a directional
pad on a remote control. It's entirely unclear to me whether the presence of
the directional pad would also cause the developers to want this behavior in
that case.

I'm going to say r=me with this, but I think we're being a bit unclear on what
DIRECTIONAL_PAD_NAVIGATION means and that could become a problem down the line.