[webkit-reviews] review requested: [Bug 23223] Teach ScheduledAction how to execute script in WorkerContext, in addition to a Document. : [Attachment 26590] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 10 14:30:54 PST 2009


Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 23223: Teach ScheduledAction how to execute script in WorkerContext, in
addition to a Document.
https://bugs.webkit.org/show_bug.cgi?id=23223

Attachment 26590: Updated patch
https://bugs.webkit.org/attachment.cgi?id=26590&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Thanks for review!
Everything fixed in this patch, except making execute() method a virtual of
ScriptExecutionContext as Alexey suggested. I really like the idea but feel
it'd be better in a separate patch (no functionality change, just code move) so
I've created a bug 23229 for that.


More information about the webkit-reviews mailing list