[webkit-reviews] review granted: [Bug 23092] Conditionalize CFNetwork-specific logic in WebKit.dll : [Attachment 26568] Revised previous patch per Adam's comments.

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Brent Fulgham
<bfulgham at gmail.com>'s request for review:
Bug 23092: Conditionalize CFNetwork-specific logic in WebKit.dll
https://bugs.webkit.org/show_bug.cgi?id=23092

Attachment 26568: Revised previous patch per Adam's comments.
https://bugs.webkit.org/attachment.cgi?id=26568&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> -HRESULT STDMETHODCALLTYPE WebCookieManager::setCookieStorage( 
> -    /* [in] */ CFHTTPCookieStorageRef storage)
> -{
> -    setCurrentCookieStorage(storage);
> -    return S_OK;
> -}
> +}
> \ No newline at end of file

You should add a newline before committing.

> +UInt32 WebDownload::bundleMagicNumber()
> +{
> +   static UInt32 bundleMagicNumber = 0xDECAF4EA;
> +   return bundleMagicNumber;
> +}

We could probably just say "return 0xDECAF4EA", but it doesn't matter too much.


It's probably possible to trim down the #includes in the new *Curl.cpp files.

r=me

I don't think any of the changes I suggested will require a re-review.