[webkit-reviews] review requested: [Bug 23092] Conditionalize CFNetwork-specific logic in WebKit.dll : [Attachment 26568] Revised previous patch per Adam's comments.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 9 12:42:41 PST 2009


Brent Fulgham <bfulgham at gmail.com> has asked  for review:
Bug 23092: Conditionalize CFNetwork-specific logic in WebKit.dll
https://bugs.webkit.org/show_bug.cgi?id=23092

Attachment 26568: Revised previous patch per Adam's comments.
https://bugs.webkit.org/attachment.cgi?id=26568&action=review

------- Additional Comments from Brent Fulgham <bfulgham at gmail.com>
A few small revisions:
1. Remove unneeded "#include <wtf/platform.h>" and #"include
<WebCore/AuthenticationCF.h>" from WebKit/win/WebDownload.cpp
2. Change BundleExtension to static method.
3. Change BundleMagicNumber to static method.
4. Use DEFINE_STATIC_LOCAL macro for bundleExtension definition.


More information about the webkit-reviews mailing list