[webkit-reviews] review granted: [Bug 22936] Uninitialized memory read error in SimpleFontData::unitsPerEm() is reported by Purify : [Attachment 26160] Initialize m_unitsPerEm in SimpleFontData constructor v2

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 22936: Uninitialized memory read error in SimpleFontData::unitsPerEm() is
reported by Purify
https://bugs.webkit.org/show_bug.cgi?id=22936

Attachment 26160: Initialize m_unitsPerEm in SimpleFontData constructor v2
https://bugs.webkit.org/attachment.cgi?id=26160&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    const unsigned cDefaultUnitsPerEm = 1000;
> +
>      class CSSFontFaceRule;
>      class CSSMutableStyleDeclaration;
>      class SVGFontElement;

We'd normally put our own declarations after any forward declarations of things
defined in other files. So this would go after the "class XXX" declarations.

We also don't use the "c" prefix for constants consistently. We're leaning more
towards just normal local-variable-style naming for constants.

r=me despite those quibbles