[webkit-reviews] review denied: [Bug 22943] Rename AffineTransform : [Attachment 26165] renames AffineTransform to TransformMatrix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 2 10:50:15 PST 2009

Darin Adler <darin at apple.com> has denied Dean Jackson <dino at apple.com>'s
request for review:
Bug 22943: Rename AffineTransform

Attachment 26165: renames AffineTransform to TransformMatrix

------- Additional Comments from Darin Adler <darin at apple.com>
You should do changes like this with the do-webcore-rename script. It handles
everything for you and almost always gets everything right. For example, it
would have corrected all the make files for platforms other than the Mac that
you neglected such as GNUMakefile.am and WebCore.vcproj.

Are you sure TransformMatrix is the best name? Transform seems to be a noun or
a verb, not an adjective. Why not TransformationMatrix?

I'm going to say review- because this would break non-Mac platforms. Once you
decide what name you like, someone can do this using do-webcore-rename; less
error prone than doing it manually.

More information about the webkit-reviews mailing list