[webkit-reviews] review requested: [Bug 23852] Rename Selection to VisibleSelection in preparation for adding new Selection class : [Attachment 27491] First pass at s/Selection/VisibleSelection

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 23852: Rename Selection to VisibleSelection in preparation for adding new
Selection class
https://bugs.webkit.org/show_bug.cgi?id=23852

Attachment 27491: First pass at s/Selection/VisibleSelection
https://bugs.webkit.org/attachment.cgi?id=27491&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
 WebCore/ChangeLog				    |  248 ++++++++
 WebCore/WebCore.base.exp			    |	15 +-
 WebCore/WebCore.pro				    |	 2 +-
 WebCore/WebCore.scons				    |	 2 +-
 WebCore/WebCore.vcproj/WebCore.vcproj		    |	16 +-
 WebCore/WebCore.xcodeproj/project.pbxproj	    |	16 +-
 WebCore/dom/Element.cpp			    |	 2 +-
 WebCore/editing/ApplyStyleCommand.cpp		    |	 4 +-
 WebCore/editing/BreakBlockquoteCommand.cpp	    |	 6 +-
 WebCore/editing/CompositeEditCommand.cpp	    |	18 +-
 WebCore/editing/CompositeEditCommand.h 	    |	 2 +-
 WebCore/editing/CreateLinkCommand.cpp		    |	 2 +-
 WebCore/editing/DeleteButtonController.cpp	    |	 4 +-
 WebCore/editing/DeleteButtonController.h	    |	 4 +-
 WebCore/editing/DeleteSelectionCommand.cpp	    |	 8 +-
 WebCore/editing/DeleteSelectionCommand.h	    |	 6 +-
 WebCore/editing/EditCommand.cpp		    |	 4 +-
 WebCore/editing/EditCommand.h			    |	14 +-
 WebCore/editing/Editor.cpp			    |	54 +-
 WebCore/editing/Editor.h			    |	10 +-
 WebCore/editing/EditorCommand.cpp		    |	12 +-
 WebCore/editing/FormatBlockCommand.cpp 	    |	 4 +-
 WebCore/editing/IndentOutdentCommand.cpp	    |	12 +-
 WebCore/editing/InsertLineBreakCommand.cpp	    |	12 +-
 WebCore/editing/InsertListCommand.cpp		    |	 6 +-
 .../editing/InsertParagraphSeparatorCommand.cpp    |	 8 +-
 WebCore/editing/InsertTextCommand.cpp		    |	 8 +-
 WebCore/editing/ModifySelectionListLevel.cpp	    |	 6 +-
 WebCore/editing/MoveSelectionCommand.cpp	    |	 4 +-
 WebCore/editing/RemoveFormatCommand.cpp	    |	 2 +-
 WebCore/editing/ReplaceSelectionCommand.cpp	    |	12 +-
 WebCore/editing/Selection.cpp			    |  651 -------------------
 WebCore/editing/Selection.h			    |  146 -----
 WebCore/editing/SelectionController.cpp	    |	32 +-
 WebCore/editing/SelectionController.h		    |	10 +-
 WebCore/editing/TypingCommand.cpp		    |	32 +-
 WebCore/editing/TypingCommand.h		    |	 2 +-
 WebCore/editing/VisiblePosition.cpp		    |	 4 +-
 WebCore/editing/VisibleSelection.cpp		    |  652 ++++++++++++++++++++
 WebCore/editing/VisibleSelection.h		    |  147 +++++
 WebCore/editing/htmlediting.cpp		    |	16 +-
 WebCore/editing/htmlediting.h			    |	 6 +-
 WebCore/editing/markup.cpp			    |	 4 +-
 WebCore/html/HTMLInputElement.cpp		    |	 4 +-
 WebCore/html/HTMLInputElement.h		    |	 4 +-
 WebCore/html/HTMLTextAreaElement.cpp		    |	 6 +-
 WebCore/html/HTMLTextAreaElement.h		    |	 4 +-
 WebCore/page/AccessibilityObject.cpp		    |	 6 +-
 WebCore/page/AccessibilityObject.h		    |	 4 +-
 WebCore/page/AccessibilityRenderObject.cpp	    |	10 +-
 WebCore/page/AccessibilityRenderObject.h	    |	 4 +-
 WebCore/page/DOMSelection.cpp			    |	24 +-
 WebCore/page/DOMSelection.h			    |	 6 +-
 WebCore/page/DragController.cpp		    |	12 +-
 WebCore/page/EditorClient.h			    |	 2 +-
 WebCore/page/EventHandler.cpp			    |	28 +-
 WebCore/page/Frame.cpp 			    |	40 +-
 WebCore/page/Frame.h				    |	16 +-
 WebCore/page/Page.cpp				    |	 2 +-
 WebCore/page/Page.h				    |	 4 +-
 WebCore/page/mac/AccessibilityObjectWrapper.mm     |	 2 +-
 WebCore/rendering/RenderBlock.cpp		    |	 2 +-
 WebCore/rendering/RenderTextControl.cpp	    |	 6 +-
 WebCore/rendering/RenderTextControl.h		    |	 4 +-
 WebCore/rendering/RenderTreeAsText.cpp 	    |	 2 +-
 WebCore/rendering/RootInlineBox.cpp		    |	 2 +-
 WebCore/svg/SVGTextContentElement.cpp		    |	 2 +-
 WebKit/mac/ChangeLog				    |	14 +
 WebKit/mac/WebView/WebFrame.mm 		    |	 2 +-
 WebKit/mac/WebView/WebView.mm			    |	 2 +-
 70 files changed, 1351 insertions(+), 1088 deletions(-)