[webkit-reviews] review granted: [Bug 23806] Night builds crash when visiting http://www.spawn.com/toys/media.aspx : [Attachment 27489] fix embed with empty src attribute crash, v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 9 12:54:46 PST 2009


Dave Hyatt <hyatt at apple.com> has granted 's request for review:
Bug 23806: Night builds crash when visiting
http://www.spawn.com/toys/media.aspx
https://bugs.webkit.org/show_bug.cgi?id=23806

Attachment 27489: fix embed with empty src attribute crash, v1
https://bugs.webkit.org/attachment.cgi?id=27489&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Just  going to + this for now, since I can't see any better way to fix it.  I
think URL just gets coincidentally set to non-null from updateResourceRequest. 
That's private in platform though so FrameLoader can't be made a friend.  We
basically need some random operation to be done on the resource request like
setting the main document URL to force an update to happen.  This all seems
really fragile and wrong, but oh well.

r=me


More information about the webkit-reviews mailing list