[webkit-reviews] review granted: [Bug 23777] Make WorkerMessagingProxy class derive from two base proxy classes. : [Attachment 27442] Proposed Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 9 02:09:37 PST 2009
Alexey Proskuryakov <ap at webkit.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 23777: Make WorkerMessagingProxy class derive from two base proxy classes.
https://bugs.webkit.org/show_bug.cgi?id=23777
Attachment 27442: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=27442&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me. I think that to validate this change, you need to also change the type of
Worker::m_messagingProxy though.
// Only use these methods on the worker object thread.
- void terminate();
bool askedToTerminate() const { return m_askedToTerminate; }
There's only one method left here, so the comment needs to be adjusted.
More information about the webkit-reviews
mailing list