[webkit-reviews] review granted: [Bug 23776] Introduce 2 base classes to split WorkerMessaingProxy. : [Attachment 27441] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 9 01:57:20 PST 2009


Alexey Proskuryakov <ap at webkit.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 23776: Introduce 2 base classes to split WorkerMessaingProxy.
https://bugs.webkit.org/show_bug.cgi?id=23776

Attachment 27441: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=27441&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +namespace WebCore {
> +    class String;

We usually add an empty line here.

+	 virtual void postMessageToWorkerContext(const String& message) = 0;
+	 virtual void postMessageToWorkerObject(const String& message) = 0;

The argument name can be omitted in these functions.

r=me


More information about the webkit-reviews mailing list