[webkit-reviews] review requested: [Bug 8475] document.lastModified gives no output if the response doesn't have a Last-Modified header : [Attachment 27287] Incorporates the style and other feedback from the review.

[bugzilla-daemon at webkit.org]

Jon at Chromium <jon at chromium.org> has asked  for review:
Bug 8475: document.lastModified gives no output if the response doesn't have a
Last-Modified header
https://bugs.webkit.org/show_bug.cgi?id=8475

Attachment 27287: Incorporates the style and other feedback from the review.
https://bugs.webkit.org/attachment.cgi?id=27287&action=review

------- Additional Comments from Jon at Chromium <jon at chromium.org>
I have incorporated the feedback from the review.  I still need to figure out
how to create a test that returns a custom header.

I understand that this behavior is in conflict with what IE and FF do when the
web server does not return a value for the Last-Modified header.  However, this
is what the specification requires.  Although returning the current time may
seem like the right thing to do, and 1970 is very unlikely, the fact is that
scripts which are returning content should return a valid date and 1970 is more
likely to catch someone's eye and lead to a fix for their incomplete headers. 
This is certainly better than the current behavior of an empty String.

This code has nothing to do with the last modified date of local files returned
with file://.  I don't know where that URL is handled so I don't know where it
is generating the Document.  It is true that when the browser is reading a file
it should properly set the last-modified date from the file system information.
 When that is fixed this fix will not longer return 1970.

I appreciate your time in reviewing this and helping me match the WebKit style.