[webkit-reviews] review granted: [Bug 23395] Web Inpsector Debugger's Source List Should Be Sorted : [Attachment 26827] updated patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted boucher
<rboucher at gmail.com>'s request for review:
Bug 23395: Web Inpsector Debugger's Source List Should Be Sorted
https://bugs.webkit.org/show_bug.cgi?id=23395

Attachment 26827: updated patch
https://bugs.webkit.org/attachment.cgi?id=26827&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
The code looks fine, but there are some coding style inconsistencies.

> +	   if (select.childNodes)
> +	   {

Brace should be on the same line as the if.

> +    while (first <= last)
> +    {

Brace should be on the same line as the while.

> +	   else
> +	   {

Brace should be on the same line as the else.

> +    return -first-1;

Should be spaces around the subtraction minus sign.

I will fix these up when I land the patch, since I feel bad for letting this
sit in review so long.