[webkit-reviews] review granted: [Bug 23358] Integrate accelerated rendering into RenderLayer : [Attachment 27267] Patch, changelog.

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 23358: Integrate accelerated rendering into RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=23358

Attachment 27267: Patch, changelog.
https://bugs.webkit.org/attachment.cgi?id=27267&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I don't think you need to null check viww() in compositor().

Remove the font smoothing stuff from RenderLayer.  That needs more discussion.

Since you complicated the syncing because of lists being dirty, maybe you could
pull that into a new function.. updateLayerListsIfNeeded or something.

Don't just comment out result.move(m_x, m_y).  Take it out in both places.

You should use an OwnPtr for m_backing.

Remove the CSSPropertyNames.h include from RenderLayer.h

The implementation of transparentAncestor is broken.  You want to walk until
you hit a layer with isComposited set, and if you encounter a transparent layer
before then, return it.  Otherwise return 0.  It should also probably be
renamed to something like transparentPaintingAncestor.

r=me making all these changes.