[webkit-reviews] review granted: [Bug 23365] Hook up accelerated compositing layers into WebHTMLView : [Attachment 27234] Revised patch, changelogs

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 23365: Hook up accelerated compositing layers into WebHTMLView
https://bugs.webkit.org/show_bug.cgi?id=23365

Attachment 27234: Revised patch, changelogs
https://bugs.webkit.org/attachment.cgi?id=27234&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Drop the "E" from ECompositingUpdate.  I prefer the enum style of including the
type in the values to help make it more clear. How about

NormalCompositingUpdate, ForcedCompositingUpdate.

Change if (!parent->renderer()->view())

to

if (parent->renderer()->documentBeingDestroyed())

Obj-C style is NSView *layerHostingView.

Remember that all code you add to WebHTMLView is just a future headache, since
we want to move to a viewless model in the future.

r=me