[webkit-reviews] review requested: [Bug 32919] svn-create-patch: fixChangeLogPatch does not work correctly in certain circumstances : [Attachment 45641] Proposed patch 3

[bugzilla-daemon at webkit.org]

Chris Jerdonek <chris.jerdonek at gmail.com> has asked  for review:
Bug 32919: svn-create-patch: fixChangeLogPatch does not work correctly in
certain circumstances
https://bugs.webkit.org/show_bug.cgi?id=32919

Attachment 45641: Proposed patch 3
https://bugs.webkit.org/attachment.cgi?id=45641&action=review

------- Additional Comments from Chris Jerdonek <chris.jerdonek at gmail.com>
In addition to David's suggested changes, I also did the following:

- Added my name to the top of VCSUtils.pm (I assume this is okay since the 
  new code is about 20% of the file).
- Added to the comments preceding fixChangeLogPatch why the function is 
  needed (from the information that David provided in an earlier comment in 
  response to my question).
- Changed the name of the new file from run-webkit-unittests-perl to 
  test-webkit-perl (as mentioned in my e-mail to webkit-dev: 
  https://lists.webkit.org/pipermail/webkit-dev/2009-December/011104.html ).

Also, I left out the VCSUtils:: prefix from the calls to fixChangeLogPatch 
in VCSUtils_unittest.pl since the unit tests run okay without it.  Let me know 

if I should have included that for reasons of good practice.