[webkit-reviews] review granted: [Bug 32844] [V8] Generate header declaration for property accessor getters/setters : [Attachment 45359] Generate property accessor getter/setter declarations.

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 32844: [V8] Generate header declaration for property accessor
getters/setters
https://bugs.webkit.org/show_bug.cgi?id=32844

Attachment 45359: Generate property accessor getter/setter declarations.
https://bugs.webkit.org/attachment.cgi?id=45359&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me with notes:

Gah! Why is this custom for V8 bindings? Need a FIXME and a bug for this.

> +	   readonly attribute [V8CustomGetter] DOMString appVersion;

Ditto.

> +		    attribute [Replaceable, V8CustomGetter] WorkerContext self;


This special-casing bonanza needs FIXMEs and bugs. We should work to remove
these.

> +    if ($dataNode->name eq "Event") {
> +	   push(@headerContent, "  static v8::Handle<v8::Value>
dataTransferAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo&
info);\n");
> +	   push(@headerContent, "  static void
valueAccessorSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value,
const v8::AccessorInfo& info);\n");
> +    }
> +    if ($dataNode->name eq "Location") {
> +	   push(@headerContent, "  static v8::Handle<v8::Value>
assignAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo&
info);\n");
> +	   push(@headerContent, "  static v8::Handle<v8::Value>
reloadAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo&
info);\n");
> +	   push(@headerContent, "  static v8::Handle<v8::Value>
replaceAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo&
info);\n");
> +    }
>  }