[webkit-reviews] review denied: [Bug 33016] [V8] Use script state of the current isolated world when creating ScriptCallStack : [Attachment 45595] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 29 09:04:00 PST 2009


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 33016: [V8] Use script state of the current isolated world when creating
ScriptCallStack
https://bugs.webkit.org/show_bug.cgi?id=33016

Attachment 45595: patch
https://bugs.webkit.org/attachment.cgi?id=45595&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
I like the premise of the patch. I don't like that we're adding extra methods
to already humongous V8Proxy and V8IsolatedWorld. ScriptState is supposed to be
a thin wrapper, and I certainly don't want us to carry it around in either of
these instances. 

Can you rework it perhaps to just add static create methods to ScriptState, and
put world-aware logic there?


More information about the webkit-reviews mailing list