[webkit-reviews] review denied: [Bug 32953] [Qt] Qt DRT: respect window.close() and window.closed() : [Attachment 45515] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 29 00:16:45 PST 2009

Eric Seidel <eric at webkit.org> has denied Robert Hogan
<robert at roberthogan.net>'s request for review:
Bug 32953: [Qt] Qt DRT: respect window.close() and window.closed()

Attachment 45515: Patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
There is really no way to know here?
4 void DumpRenderTree::windowCloseRequested()
 755 {
 756	 // We don't know which window was closed, so we have to assume it was
the one
 757	 // most recently opened.
 758	 if (windows.count()) {
 759	     QObject* container = windows.takeLast();
 760	     container->deleteLater();
 761	 }
 762 }

The tabs will prevent this from being landed as is.

More information about the webkit-reviews mailing list