[webkit-reviews] review denied: [Bug 32963] buildfix for ResourceHandleWin.cpp : [Attachment 45527] Buildfix for ResourceHandleWin.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 29 00:14:53 PST 2009


Eric Seidel <eric at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 32963: buildfix for ResourceHandleWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=32963

Attachment 45527: Buildfix for ResourceHandleWin.cpp
https://bugs.webkit.org/attachment.cgi?id=45527&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Please explain your changes in the ChangeLog.  There are too many, too
complicated changes for this to be reviewed with such an empty ChangeLog.

For example, why this?
-	 if (method() == "POST") {
+	 if (request().httpMethod() == "POST") {

And this?
+#ifdef RESOURCE_LOADER_DEBUG
+	 char buf[64];
+	 _snprintf(buf, sizeof(buf), "Load error: %i\n", error);
+	 OutputDebugStringA(buf);
+#endif


More information about the webkit-reviews mailing list