[webkit-reviews] review denied: [Bug 32009] Crash in RenderBlock::startDelayUpdateScrollInfo : [Attachment 44056] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 28 18:24:40 PST 2009


Maciej Stachowiak <mjs at apple.com> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 32009: Crash in RenderBlock::startDelayUpdateScrollInfo
https://bugs.webkit.org/show_bug.cgi?id=32009

Attachment 44056: Patch v1
https://bugs.webkit.org/attachment.cgi?id=44056&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
I suggest reducing the comment to one line:

// updateScrollInfoAfterLayout() may modify gDelayedUpdateScrollInfoSet, so
save a copy

This idiom is common in WebKit so excessive explanation is not needed. Fix that
and I'll gladly r+ this patch.


More information about the webkit-reviews mailing list