[webkit-reviews] review denied: [Bug 31265] Find a new home for setUseSecureKeyboardEntry (and Mac implementation) : [Attachment 44244] Incremental improvement, v4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 28 18:21:03 PST 2009


Maciej Stachowiak <mjs at apple.com> has denied Stuart Morgan
<stuartmorgan at chromium.org>'s request for review:
Bug 31265: Find a new home for setUseSecureKeyboardEntry (and Mac
implementation)
https://bugs.webkit.org/show_bug.cgi?id=31265

Attachment 44244: Incremental improvement, v4
https://bugs.webkit.org/attachment.cgi?id=44244&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
> #if PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN))
> #define USES_CARBON_SECURE_INPUT_MODE 1
> #endif

I think the right way to do this is to make a WTF-style USE macro as in
Platform.h, so at the use site it's #if USE(CARBON_SECURE_INPUT_MODE)

r- to consider this suggestion. Otherwise looks ok to me.


More information about the webkit-reviews mailing list