[webkit-reviews] review granted: [Bug 32905] With Pinyin Simplified IM, a wrong character is deleted from google.com suggestion : [Attachment 45444] proposed fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 32905: With Pinyin Simplified IM, a wrong character is deleted from
google.com suggestion
https://bugs.webkit.org/show_bug.cgi?id=32905

Attachment 45444: proposed fix
https://bugs.webkit.org/attachment.cgi?id=45444&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   // An open typing command that disagrees about current selection
would cause issues with typing later on.
> +	   if (m_lastEditCommand && m_lastEditCommand->isTypingCommand())
> +	      
static_cast<TypingCommand*>(m_lastEditCommand.get())->closeTyping();

I think this needs to check isOpenForMoreTyping before just calling
closeTyping. Luckily there is a helper function for this. You should just
write:

    TypingCommand::closeTyping(m_lastEditCommand);

The class member function handles the null check too.

r=me if you change it like I suggest