[webkit-reviews] review granted: [Bug 29968] Selecting text with text-overflow ellipsis should not show cut off text : [Attachment 45461] Prevents the cut off text from being shown, also makes highlight cover all of ellipsis instead of allowing for partial selection (version 4)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 23 20:11:38 PST 2009


mitz at webkit.org has granted Jessie Berlin <jberlin at webkit.org>'s request for
review:
Bug 29968: Selecting text with text-overflow ellipsis should not show cut off
text
https://bugs.webkit.org/show_bug.cgi?id=29968

Attachment 45461: Prevents the cut off text from being shown, also makes
highlight cover all of ellipsis instead of allowing for partial selection
(version 4)
https://bugs.webkit.org/attachment.cgi?id=45461&action=review

------- Additional Comments from mitz at webkit.org
> +	       EllipsisBox* ellipsis;
> +	       if ((ellipsis = box->root()->ellipsisBox())) {

can be written as
	   if (EllipsisBox* ellipsis = box->root()->ellipsisBox()) {

r=me!


More information about the webkit-reviews mailing list