[webkit-reviews] review requested: [Bug 28245] findNextLineBreak crashes when inserting a blank span in front of a long line : [Attachment 45431] Bug fix patch - Removed tabs

[bugzilla-daemon at webkit.org]

Mike Moretti <webkit9 at mordent.com> has asked  for review:
Bug 28245: findNextLineBreak crashes when inserting a blank span in front of a
long line
https://bugs.webkit.org/show_bug.cgi?id=28245

Attachment 45431: Bug fix patch - Removed tabs
https://bugs.webkit.org/attachment.cgi?id=45431&action=review

------- Additional Comments from Mike Moretti <webkit9 at mordent.com>
Sorry about the tabs.  I removed them now.

As for the indexing, I didn't want to use indexing because "characters"
actually returns null, not a valid string (I don't know what "text()" does yet
without looking further).

I also wasn't sure if textLength() would ever return a -1; I am still not as up
to speed on the webkit code as I would like yet.

I looked at 3 or 4 test cases to find one to use as an example but wasn't sure
which was best, so I randomly picked one and it had alerts in it.  If you can
point me to a better example that would be great!  I would rather write a
proper test case next time.