[webkit-reviews] review requested: [Bug 32898] [Qt] Add page zooming support to Qt DumpRenderTree : [Attachment 45430] Adds page zooming support for Qt DumpRenderTree and removes three tests from the skipped list

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 23 04:18:28 PST 2009


Kim Grönholm <kim.gronholm at nomovok.com> has asked  for review:
Bug 32898: [Qt] Add page zooming support to Qt DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=32898

Attachment 45430: Adds page zooming support for Qt DumpRenderTree and removes
three tests from the skipped list
https://bugs.webkit.org/attachment.cgi?id=45430&action=review

------- Additional Comments from Kim Grönholm <kim.gronholm at nomovok.com>
Added a patch to fix this issue.

One of the tests needed minor refactoring because it failed due to
"layoutTestController.notifyDone();" stopping the execution and
therefore the lines:
PASS successfullyParsed is true

TEST COMPLETE
never got outputted. I mimic some other tests and changed it accordingly
and now it works.


More information about the webkit-reviews mailing list