[webkit-reviews] review denied: [Bug 27243] SVG JS bindings "context" pointer needs to move onto binding impls : [Attachment 45353] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 21 22:10:47 PST 2009

Sam Weinig <sam at webkit.org> has denied Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 27243: SVG JS bindings "context" pointer needs to move onto binding impls

Attachment 45353: Patch v1

------- Additional Comments from Sam Weinig <sam at webkit.org>
This looks good to me, though at some point I think we should take it a step
further and move this stuff completely out of the bindings, and into the core
implementation.  As for tests, fast/dom/prototype-inheritance.html and
fast/dom/prototype-inheritance-2.html should be good tests to look at to test
this, but they are probably not currently being hit, because the SVG objects
don't all have interfaces on the window or because it takes more effort to make
one of these guys that simply iterating the window object. I would say r=me,
but I think you should try and make a test first.

More information about the webkit-reviews mailing list