[webkit-reviews] review denied: [Bug 32820] check-webkit-style fails if Git is configured with diff.mnemonicprefix : [Attachment 45321] check-webkit-style: Add support for Git's "diff.mnemonicprefix" config option

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 21 21:51:32 PST 2009


Eric Seidel <eric at webkit.org> has denied Tor Arne Vestbø <vestbo at webkit.org>'s
request for review:
Bug 32820: check-webkit-style fails if Git is configured with
diff.mnemonicprefix
https://bugs.webkit.org/show_bug.cgi?id=32820

Attachment 45321: check-webkit-style: Add support for Git's
"diff.mnemonicprefix" config option
https://bugs.webkit.org/attachment.cgi?id=45321&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I expect other tools, like svn-apply (seen VCSTools.pm) will have trouble with
this git setting as well.

This change is in our python code and requires a unit test.


More information about the webkit-reviews mailing list