[webkit-reviews] review granted: [Bug 32261] Add ability to specify suggested autocomplete value in HTMLInputElement : [Attachment 44985] Added ability to separate autocomplete suggestion previewing from accepting of the suggested value in HTMLInputElement / RenderTextControlSingleLine

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 16 09:47:01 PST 2009


Darin Adler <darin at apple.com> has granted Zelidrag Hornung
<zelidrag at chromium.org>'s request for review:
Bug 32261: Add ability to specify suggested autocomplete value in
HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=32261

Attachment 44985: Added ability to separate autocomplete suggestion previewing
from accepting of the suggested value in HTMLInputElement /
RenderTextControlSingleLine
https://bugs.webkit.org/attachment.cgi?id=44985&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   No new tests. This new methods are not exposed yet. It's use will be

> +	   platform specific. Chromium specific changes are separated based on
> +	   Darin Adler's comments and they are coming soon.

I think there was a misunderstanding. I suggested separating PopupMenu changes,
not separating Chromium-specific changes. If there are Chromium-specific
changes that relate directly to this patch, I could see them going in at the
same time.

r=me


More information about the webkit-reviews mailing list