[webkit-reviews] review granted: [Bug 32609] Web Inspector: Make Elements tree, properties section and resources view monospace. : [Attachment 44974] [PATCH] Same with fix for windows platform and console prompt.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 16 09:45:42 PST 2009


Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 32609: Web Inspector: Make Elements tree, properties section and resources
view monospace.
https://bugs.webkit.org/show_bug.cgi?id=32609

Attachment 44974: [PATCH] Same with fix for windows platform and console
prompt.
https://bugs.webkit.org/attachment.cgi?id=44974&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +		   span.addStyleClass("console-formatted-trace source code");

Should be source-code.


> +    white-space: pre;

This should be pre-wrap, pre is pretty dangerous.


> +    font-family: Monaco, monospace;

Some people are going to ask for Menlo on Snow Leopard… But alti-alias
monospace is pretty bad in my book. So I think Monaco is good.

Fix the class name before landing.


More information about the webkit-reviews mailing list